Add caching to DefaultTypeResolver (issue #437)

Farfetch · Oct 8, 2023 · d5ae9dd · d5ae9dd
1 parent d662b9d
commit d5ae9dd
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/src/KafkaFlow.Serializer/DefaultTypeResolver.cs b/src/KafkaFlow.Serializer/DefaultTypeResolver.cs
@@ -1,18 +1,22 @@
 namespace KafkaFlow
 {
     using System;
+    using System.Collections.Concurrent;
 
     internal class DefaultTypeResolver : IMessageTypeResolver
     {
         private const string MessageType = "Message-Type";
 
+        private static readonly ConcurrentDictionary<string, Type> ConsumeTypeCache = new(StringComparer.Ordinal);
+        private static readonly ConcurrentDictionary<Type, string> ProduceTypeCache = new();
+
         public Type OnConsume(IMessageContext context)
         {
             var typeName = context.Headers.GetString(MessageType);
 
             return typeName is null ?
-                null :
-                Type.GetType(typeName);
+               null :
+               ConsumeTypeCache.GetOrAdd(typeName, Type.GetType);
         }
 
         public void OnProduce(IMessageContext context)
@@ -24,9 +28,11 @@ public void OnProduce(IMessageContext context)
 
             var messageType = context.Message.Value.GetType();
 
-            context.Headers.SetString(
-                MessageType,
-                $"{messageType.FullName}, {messageType.Assembly.GetName().Name}");
+            string messageTypeName = ProduceTypeCache.GetOrAdd(
+                messageType,
+                static messageType => $"{messageType.FullName}, {messageType.Assembly.GetName().Name}");
+
+            context.Headers.SetString(MessageType, messageTypeName);
         }
     }
 }