-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement v3 main features #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeesch
force-pushed
the
workers-calculator
branch
10 times, most recently
from
July 11, 2023 21:50
8eef406
to
1aa6589
Compare
filipeesch
force-pushed
the
workers-calculator
branch
8 times, most recently
from
July 15, 2023 12:46
b50b7ea
to
413e24a
Compare
filipeesch
commented
Sep 11, 2023
samples/KafkaFlow.Sample.BatchOperations/KafkaFlow.Sample.BatchOperations.csproj
Outdated
Show resolved
Hide resolved
samples/KafkaFlow.Sample.BatchOperations/PrintConsoleMiddleware.cs
Outdated
Show resolved
Hide resolved
samples/KafkaFlow.Sample.BatchOperations/PrintConsoleMiddleware.cs
Outdated
Show resolved
Hide resolved
filipeesch
force-pushed
the
workers-calculator
branch
3 times, most recently
from
September 14, 2023 15:44
b4caa6e
to
d84707d
Compare
filipeesch
changed the title
feat: enable dynamic worker calculation
Implement v3 main features
Sep 15, 2023
filipeesch
force-pushed
the
workers-calculator
branch
2 times, most recently
from
September 19, 2023 10:50
057c6fd
to
59e8adf
Compare
filipeesch
requested review from
gsferreira,
joelfoliveira and
ailtonguitar
September 19, 2023 11:34
filipeesch
force-pushed
the
workers-calculator
branch
from
September 27, 2023 12:22
49d7875
to
18e25e1
Compare
joelfoliveira
approved these changes
Sep 27, 2023
src/KafkaFlow.Abstractions/Configuration/IConsumerConfigurationBuilder.cs
Show resolved
Hide resolved
filipeesch
force-pushed
the
workers-calculator
branch
2 times, most recently
from
September 28, 2023 10:58
80b6c90
to
0970b4c
Compare
brmagadutra
approved these changes
Sep 28, 2023
gsferreira
reviewed
Sep 29, 2023
ruiqbarbosa
reviewed
Sep 29, 2023
src/KafkaFlow/Consumers/WorkersBalancers/ConsumerLagWorkerBalancer.cs
Outdated
Show resolved
Hide resolved
erik-catalao
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
samples/KafkaFlow.Sample.PauseConsumerOnError/PauseConsumerOnExceptionMiddleware.cs
Show resolved
Hide resolved
joelfoliveira
approved these changes
Sep 30, 2023
fix: change dependency injection lifetime management for worker and consumer/producer fix: create AdminClient without authentication perf: memory optimizations on MessageContext
filipeesch
force-pushed
the
workers-calculator
branch
from
October 2, 2023 14:37
0970b4c
to
805f0f2
Compare
ruiqbarbosa
approved these changes
Oct 2, 2023
JoaoRodriguesGithub
approved these changes
Oct 3, 2023
filipeesch
force-pushed
the
workers-calculator
branch
from
October 3, 2023 13:27
8c785d9
to
5b65529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request implements the main features of 3.0 version:
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement