Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: update dashboard and client app routes to kafkaflow #416

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix!: update dashboard and client app routes to kafkaflow #416

merged 1 commit into from
Sep 19, 2023

Conversation

jose-sousa-8
Copy link
Contributor

@jose-sousa-8 jose-sousa-8 commented Jul 26, 2023 •
edited
Loading

Description

Updated routes and dashboard routes to point to kafkaflow instead of kafka-flow
Created unit tests for admin api controllers.
Updated documentation accordingly.

Fixes #303

How Has This Been Tested?

  • Ran the KafkaFlow.Sample.WebApi sample project and ensured every endpoint was working propertly
  • Ran the KafkaFlow.Sample.Dashboard sample project and ensure that it was now accessible at /kafkaflow instead of /kafka-flow

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

@jose-sousa-8 jose-sousa-8 marked this pull request as ready for review July 28, 2023 21:24
@gsferreira
Copy link
Contributor

This is a breaking change.
I should target a new 3.0 branch instead of master.

@gsferreira gsferreira added this to the v3.0.0 milestone Jul 31, 2023
@jose-sousa-8 jose-sousa-8 changed the base branch from master to release/3.0 September 12, 2023 12:49
@jose-sousa-8
Copy link
Contributor Author

This is a breaking change. I should target a new 3.0 branch instead of master.

Updated target branch to release/3.0

@jose-sousa-8 jose-sousa-8 changed the title fix: update dashboard and client app routes to kafkaflow fix!: update dashboard and client app routes to kafkaflow Sep 18, 2023
@filipeesch filipeesch merged commit 4e37f85 into Farfetch:release/3.0 Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipeesch filipeesch filipeesch approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Administration Projects - Rename paths to kafkaflow instead of kafka-flow
3 participants
@jose-sousa-8 @gsferreira @filipeesch