Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: upgrade to .net 6 #418

Merged
merged 1 commit into from
Sep 19, 2023
Merged

chore!: upgrade to .net 6 #418

merged 1 commit into from
Sep 19, 2023

Conversation

jose-sousa-8
Copy link
Contributor

@jose-sousa-8 jose-sousa-8 commented Jul 29, 2023 •
edited
Loading

Description

  • Upgrade Framework and Sample Projects to .NET 6
  • Update C# language version from 9 to 10

Fixes #298 #322

How Has This Been Tested?

Ran both WebApi and Dashboard samples.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes (N/A?)
  • I have made corresponding changes to the documentation (did not find any doc related to the .net versioning will be added in the release notes?)

@jose-sousa-8 jose-sousa-8 marked this pull request as ready for review July 29, 2023 19:04
@gsferreira gsferreira added this to the v3.0.0 milestone Jul 31, 2023
@gsferreira
Copy link
Contributor

@joelfoliveira @jose-sousa-8 I think we to target this to a 3.0 branch related to the milestone https://github.com/Farfetch/kafkaflow/milestone/1

@jose-sousa-8 jose-sousa-8 changed the base branch from master to release/3.0 September 12, 2023 12:52
@jose-sousa-8
Copy link
Contributor Author

@joelfoliveira @jose-sousa-8 I think we to target this to a 3.0 branch related to the milestone https://github.com/Farfetch/kafkaflow/milestone/1

updated target branch to release/3.0

@filipeesch
Copy link
Contributor

filipeesch commented Sep 18, 2023 •
edited
Loading

please, change the commit message and PR title prefix from "feat" to "chore" ;)

@jose-sousa-8 jose-sousa-8 changed the title feat: upgrade to .net 6 chore: upgrade to .net 6 Sep 18, 2023
@jose-sousa-8 jose-sousa-8 changed the title chore: upgrade to .net 6 chore!: upgrade to .net 6 Sep 18, 2023
@filipeesch filipeesch added enhancement New feature or request breaking change labels Sep 19, 2023
@filipeesch filipeesch merged commit cf040de into Farfetch:release/3.0 Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipeesch filipeesch filipeesch approved these changes

Assignees
No one assigned
Labels
breaking change enhancement New feature or request
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

.NET 6
3 participants
@jose-sousa-8 @gsferreira @filipeesch