Adapt OpenTelemetry to KafkaFlow 3.0 #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simaoribeiro
requested review from
joelfoliveira,
filipeesch,
ailtonguitar,
brmagadutra,
ruiqbarbosa,
JoaoRodriguesGithub and
erik-catalao
ruiqbarbosa
approved these changes
Oct 25, 2023
joelfoliveira
approved these changes
Oct 25, 2023
JoaoRodriguesGithub
approved these changes
Oct 26, 2023
simaoribeiro
force-pushed
the
feat/adapt-open-telemetry-to-3.0
branch
from
ae1c60e
to
d632c08
Compare
brmagadutra
approved these changes
Oct 30, 2023
src/KafkaFlow.OpenTelemetry/OpenTelemetryConsumerEventsHandler.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.OpenTelemetry/OpenTelemetryConsumerEventsHandler.cs
Outdated
Show resolved
Hide resolved
simaoribeiro
force-pushed
the
feat/adapt-open-telemetry-to-3.0
branch
2 times, most recently
from
076456e
to
f8840a9
Compare
ailtonguitar
reviewed
Nov 6, 2023
src/KafkaFlow.OpenTelemetry/OpenTelemetryConsumerEventsHandler.cs
Outdated
Show resolved
Hide resolved
ailtonguitar
reviewed
Nov 6, 2023
ailtonguitar
reviewed
Nov 6, 2023
src/KafkaFlow.OpenTelemetry/OpenTelemetryProducerEventsHandler.cs
Outdated
Show resolved
Hide resolved
simaoribeiro
force-pushed
the
feat/adapt-open-telemetry-to-3.0
branch
2 times, most recently
from
604e2a5
to
5242704
Compare
Include peer.service tag for producer and consumer spans Close consumer span when Complete() is invoked to have a correctly time closing for both single and batch consumers
ailtonguitar
approved these changes
Nov 7, 2023
simaoribeiro
force-pushed
the
feat/adapt-open-telemetry-to-3.0
branch
from
5242704
to
a186364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
peer.serviceattribute in the Consumer and Producer spans.Complete()method is invokedHow Has This Been Tested?
Integration tests
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement