fix: broken traces #467
Closed
fix: broken traces #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simaoribeiro
force-pushed
the
fix/-broken-traces
branch
4 times, most recently
from
29ce080
to
9eaa029
Compare
simaoribeiro
requested review from
filipeesch,
ailtonguitar,
joelfoliveira,
brmagadutra and
ruiqbarbosa
simaoribeiro
force-pushed
the
fix/-broken-traces
branch
2 times, most recently
from
d11e439
to
d6d3f7e
Compare
brmagadutra
approved these changes
Nov 13, 2023
brmagadutra
reviewed
Nov 13, 2023
joelfoliveira
approved these changes
Nov 14, 2023
|
simaoribeiro
force-pushed
the
fix/-broken-traces
branch
from
cf9573a
to
a935e13
Compare
Activity.Current is a static variable that uses AsyncLocal internally, which means that it flows into async calls, but not back out into the caller (message consumer and producer). As so, the activity.current is null after the produce and consume of the message, which means that all the spans created after it will be generate a new trace because the context is not being propagated.
simaoribeiro
force-pushed
the
fix/-broken-traces
branch
from
a935e13
to
8172b54
Compare
JoaoRodriguesGithub
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken traces by changing the Activity creation to
KafkaFlowproject, just before the messages are consumed and produced.The error appeared because the Activity context, being created in
KafkaFlow.OpenTelemetry, could not be propagated through the system and the next time a span would be created the existing Activity would be null, forcing the creation of a new trace instead of using the previous oneCloses #468
How Has This Been Tested?
Integration tests
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement