Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate DI registration of IClusterManagerAccessor #529

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

gnjack
Copy link
Contributor

@gnjack gnjack commented Feb 21, 2024

Description

IClusterManagerAccessor is already registered as a singleton a few lines above.

Looks like this line was accidentally duplicated in 3f996b6#diff-ad7219aa5db9d536244342b218fd6ef245e685445e173b747ef99513d520dbc4R52

The duplicate registration breaks our Ninject DI implementation:

Ninject.ActivationException : Error activating IConsumerManagerFactory
More than one matching bindings are available.
Matching bindings:
  1) binding from IConsumerManagerFactory to constant value
  2) binding from IConsumerManagerFactory to constant value
Activation path:
  1) Request for IConsumerManagerFactory

Suggestions:
  1) Ensure that you have defined a binding for IConsumerManagerFactory only once.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@brmagadutra brmagadutra merged commit db7f7e3 into Farfetch:master Mar 6, 2024
3 checks passed
@gnjack gnjack deleted the patch-2 branch April 2, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants