fix: out of order production issue #567
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,6 +62,7 @@ public interface IMessageProducer | |||
| /// <param name="headers">The message headers</param> | |||
| /// <param name="deliveryHandler">A handler with the operation result</param> | |||
| /// <param name="partition">The partition where the message will be produced, if no partition is provided it will be calculated using the message key</param> | |||
| [Obsolete("This method will be remove in the next major release, please use ProduceAsync() instead")] | |||
There was a problem hiding this comment.
Why are we marking the Produce methods as obsolete? In scenarios where the message throughput is high, the non async producer can produce at a significant higher rate since it doesn't need to wait for the report.
Why can't the framework support this?
|
Sorry, a bit confused here. If the issue is related to calling the ProduceAsync without await, isn't expected that the Task execution order cannot be guaranteed? In .NET ecosystem, this is expected since it is the way that .NET handles task execution. If the caller does not want to wait for the delivery report, as an alternative, can use the non-async producer or set the aks to 0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue that the messages are published in the wrong order when we call ProduceAsync() many times without awaiting.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement