Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix samples broken link #11

Closed
wants to merge 1 commit into from
Closed

Conversation

QzLP2P
Copy link
Contributor

@QzLP2P QzLP2P commented Feb 21, 2024

Link was wrong

Description

The link in samples.md was wrong

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

Link was wrong
@joelfoliveira
Copy link
Contributor

Hi @QzLP2P ,

Thank you for your contribution. As per the Contribuiting Guidelines, can you please change the commit message to follow the conventional commits guideline?

Maybe something like: docs: fix samples broken link

@QzLP2P QzLP2P changed the title Update samples.md docs: fix samples broken link Feb 21, 2024
@simaoribeiro
Copy link
Contributor

Hi @QzLP2P , I noticed that you changed the PR title to the one suggested by @joelfoliveira . Can you also reword the commit title from Update samples.md to the docs: fix samples broken link to follow our guidelines? Thanks

@QzLP2P
Copy link
Contributor Author

QzLP2P commented Feb 21, 2024

Hi @QzLP2P ,

Thank you for your contribution. As per the Contribuiting Guidelines, can you please change the commit message to follow the conventional commits guideline?

Maybe something like: docs: fix samples broken link

I tried from github.com but I can’t rewrite the commit message.
Tomorrow I Will clone the repo to do it

@QzLP2P QzLP2P closed this Feb 22, 2024
@QzLP2P
Copy link
Contributor Author

QzLP2P commented Feb 22, 2024

I finally create a new one, more simple for me #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants