Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix part of #4668 #4669

Closed
wants to merge 1 commit into from
Closed

Conversation

wesleyking0
Copy link

To fully resolve the #4668 problem, it may require two steps:

  • Skip resolving the @JsonTypeInfo annotation if a subtype is defined with @JsonTypeInfo and its definition is not compatible with the superclass.
  • Confirming a more specific type during deserialization.

I have completed the first step, but I don't have a pretty good idea for the second step yet. -:)

@cowtowncoder
Copy link
Member

cowtowncoder commented Aug 20, 2024

I don't think I will be accepting this since usage on #4668 is wrong -- subtypes are not expected to change @JsonTypeInfo definition.

Put another way, @JsonTypeInfo definitions must be consistent across type hierarchy.

@cowtowncoder
Copy link
Member

I don't think #4668 should be done in general, so not proceeding with this PR either, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants