Move to Github145.testPerson7() failing test
#802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
approved these changes
May 31, 2024
|
I think we should get this merged. |
Maybe @dinomite could help? |
|
@JooHyukKim Ah. I forgot that you probably do not yet have access to merge this. I do, will merge. |
|
Merged to 2.18, up to |
3 tasks
|
@JooHyukKim @cowtowncoder By the way, can this test be removed? Therefore, I feel that this test should be removed. |
|
@k163377 Ultimately you are the module owner so I think your judgment is best here. FWTW I think you are right about test being broken so yeah, let's just remove it. |
k163377
added a commit
to k163377/jackson-module-kotlin
that referenced
this pull request
Jun 9, 2024
Merged
|
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers #801.
Refer to #375