Add kotlin sources for maven-source-plugin #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add maven-source-plugin and build-helper-maven-plugin to attach mixed java+kotlin sources, as this SO answer suggests.
I see that the
source:jar
command is called in a GitHub workflow, so explicitly putting the maven-source-plugin in the pom is not necessary. If I run./mvnw source:jar
locally, it will generate the sources including the kotlin files correctly, where the plugin configuration is inherited from oss-parent.This should fix #171. In the first pull request to fix this, #175, I find that that author also included:
But I didn't see how this is necessary.
When this fix is verified, it can also be backported to 2.18 and 2.17.
Since I didn't make any code changes, do I still need to fill out the Contributor Licence Agreement?