-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bug report #840
Update bug report #840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cowtowncoder
I would like to make a change to allow users to check more meaningfully before submitting an issue.
Could you please confirm the details?
@@ -10,14 +10,17 @@ body: | |||
label: Search before asking | |||
description: |- | |||
Please search [issues](https://github.com/FasterXML/jackson-module-kotlin/issues) to check if your issue has already been reported. | |||
Check [all value class labeled issues](https://github.com/FasterXML/jackson-module-kotlin/issues?q=is%3Aopen+is%3Aissue+label%3A%22value+class%22), especially if the problem is related to a value class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value class
behaved differently than expected and was difficult to search by the user.
Therefore, I have added a statement that prompts the user to check all labeled issues.
Also, KotlinModule is only an extension of databind, so it is not an appropriate place to report problems with databind or other modules. | ||
Please try to ensure that the problem occurs only in Kotlin, and not regular Java objects. | ||
options: | ||
- label: "I searched in the [issues](https://github.com/FasterXML/jackson-module-kotlin/issues) and found nothing similar." | ||
required: true | ||
- label: "I have confirmed that the same problem is not reproduced if I exclude the KotlinModule." | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the problem is not related to KotlinModule
, it can often be reproduced without KotlinModule
, so I have added a procedure.
- label: "I searched in the [issues of databind](https://github.com/FasterXML/jackson-databind/issues) and other modules used and found nothing similar." | ||
required: false | ||
- label: "I have confirmed that the problem only occurs when using Kotlin." | ||
- label: "I have confirmed that the problem does not reproduce in Java and only occurs when using Kotlin and KotlinModule." | ||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, it should be submitted after confirming that it does not reproduce at all with Java
only, so I have added language so that it can be read.
However, since this is basically difficult, it continues to not be required.
@k163377 Seems reasonable to me. Unfortunately many submitters just skip about all verbiage... but this could be useful for those that do not. |
Added language to encourage more investigation of frequently reported duplicate/unrelated
KotlinModule
issues.