Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android Record Module #227

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Add Android Record Module #227

merged 4 commits into from
Nov 10, 2023

Commits on Oct 27, 2023

  1. Add Android Record Module

    @eranl
    eranl committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    1a3541c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Add jackson-core dependency, animal-sniffer-maven-plugin, per review … 

    …comments
    @eranl
    eranl committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    d6c4b7d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Addressed review comments 

    With the goal of maximizing consistency with built-in record support, I copied and "desugared" some unit tests from https://github.com/FasterXML/jackson-databind/tree/2.16/src/test-jdk17/java/com/fasterxml/jackson/databind/records. A few of the test cases are failing, and I marked them with a "Failing" comment and a "notest" name prefix. I'm hoping for guidance about whether and how I should fix them.
Fixed handling of getters
Added support for injected values
Added use of constructor parameter names
Skip module if class already has a withArgsCreator
    @eranl
    eranl committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    102e00b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Updated doc. 

    Moved failing tests to 'failing' package.
Added test for differing generic parameter types.
Pruned BaseTest and BaseMapTest.
Added comment about '-parameters' compiler option.
    @eranl
    eranl committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    cc269c5 View commit details
    Browse the repository at this point in the history