android-record: Adapt generic types returned by Android reflection to follow Java behavior #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… follow Java behavior.
… follow Java behavior.
cowtowncoder
approved these changes
Sep 4, 2024
|
Forgot to ask for a unit test to show the fix, but not sure how feasible that'd have been. Merged for 2.18.0, regardless. |
|
Oh yeah, unfortunately the behavior only occurs on Android, so I don't think it would be actually testable wirhout stubbing its reflection classes on desktop. Thank you. |
|
Right, that makes sense. Thank you for confirming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251.
This PR adds a method to AndroidRecordModule that fixes/resolves GenericArrayTypes and ParameterizedTypes returned by Android reflection on method/constructor parameters. In turn, they behave the same as field types and constructor recognition on records that use both arrays and generic types no longer fails.
The type resolution method is compatible with the one in Android here: https://android.googlesource.com/platform/libcore/+/refs/heads/main/luni/src/main/java/libcore/reflect/ParameterizedTypeImpl.java#75
with the difference that it automatically resolves arrays fully where possible instead of returning an instance of GenericArrayType even on non-generic arrays (which causes errors in the current behaviour).