Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-deepl): add appInfo to DeepL Translator options #326

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

sargreal
Copy link
Member

A requirement/advisory from the DeepL nodejs documentation: deepl-node#writing-a-plugin

@sargreal sargreal self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #326 (cbb68bf) into main (b936ec6) will increase coverage by 0.06%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   45.89%   45.95%   +0.06%     
==========================================
  Files          47       47              
  Lines         865      866       +1     
  Branches      187      187              
==========================================
+ Hits          397      398       +1     
  Misses        310      310              
  Partials      158      158              
Flag Coverage Δ
unittests 45.95% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
providers/deepl/lib/constants.js 100.00% <100.00%> (ø)
providers/deepl/lib/index.js 75.00% <ø> (ø)

@sargreal sargreal merged commit ec58e66 into main Nov 2, 2023
22 checks passed
@fekide-bot
Copy link

🎉 This PR is included in version 1.0.10 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.2.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@fekide-bot
Copy link

🎉 This PR is included in version 1.1.11 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@sargreal sargreal deleted the fix/add-app-info-deepl branch February 4, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants