Fix memory leak because WebRequestMonitor.tabInfo is never removed #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabInfo grows over time and extension is allocating more and more memory. chrome.tabs.onRemoved.addListener is getting integer tabId, not tab object.
PetrP
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed that when browser is running for longer time (days/weeks), the extension has masive memory footprint (hundreds of MB).
I investigated a little and noticed that WebRequestMonitor.tabInfo is never removed,
and it is because chrome.tabs.onRemoved.addListener had wrong parameter.
Compatibility
yes