Fixes display of mj-sections with background image in some Outlook versions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvallant
changed the title
|
Thank you for spotting this problem - somehow I messed up when I created the initial port. Indeed, these problems won't be detected in our current testing. I hope you did not have to spend a lot of time debugging this. |
Well I did. 😿 But I guess that's more Outlook's fault! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output for mj-sections using a background image is wrong compared with the original MJML implementation; the
<v:rect>tag was incorrectly closed (though there was a closing tag already coming afterwards) and the order of some Outlook specific tags was wrong.Note that these things don't get caught in the tests, most likely because they are conditional HTML comments.