Skip to content

Commit

Permalink
Update notes after testing
Browse files Browse the repository at this point in the history
  • Loading branch information
FenPhoenix committed Oct 27, 2023
1 parent 7bc7c66 commit 12087a1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
3 changes: 1 addition & 2 deletions AngelLoader/TDM/TDMParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ namespace AngelLoader;

internal static class TDMParser
{
// @TDM: Test with a fresh install of TDM where no FMs dir exists, or no missions.tdminfo exists, etc.

// Works fine when missions.tdminfo doesn't exist, just returns an empty list.
internal static List<TDM_LocalFMData> ParseMissionsInfoFile()
{
const string missionInfoId = "tdm_missioninfo";
Expand Down
11 changes: 8 additions & 3 deletions AngelLoader/TDM/TDMWatchers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,14 @@ static bool TryGetLines(string file, [NotNullWhen(true)] out List<string>? lines
}
}

// @TDM(Watchers): If we don't have an fms dir, all watchers are disabled. Should we be smarter?
// Should we try to have it auto-pick-up the fms dir if it's created and start watching, then stop if it's
// removed? Do we need the same currentfm.txt?
/*
@TDM(Watchers): If we don't have an fms dir, all watchers are disabled.
-currentfm.txt is fine, the watcher works even if there isn't one and then one is created.
-missions.tdminfo is also fine, if missing the watcher will pick it back up when it gets created and modified.
-A fresh TDM install puts the fms dir there already as it comes with a few FMs, so we can probably just
ignore the edge case of no fms dir. It's highly unlikely to occur, and all it results in is auto-refresh
shutting off until the next app run.
*/
internal static void DeferredWatchersEnable(bool enableTDMWatchers)
{
string gamePath = Config.GetGamePath(GameIndex.TDM);
Expand Down

0 comments on commit 12087a1

Please sign in to comment.