Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-looped animation interpolation #285

Open
wants to merge 1 commit into
base: 1.20
Choose a base branch
from

Conversation

soup587
Copy link
Contributor

@soup587 soup587 commented Dec 18, 2024

(almost 2am commit, please tell me if i'm doing any of these poorly)

Copy link

@PoolloverNathan PoolloverNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I have not tested or looked at the code whatsoever)

@soup587
Copy link
Contributor Author

soup587 commented Dec 18, 2024

at the very least it does in fact fix non-looped animation interpolation for the ones i tested, and doesn't seem to break others from my testing

Copy link
Contributor

@TheBunnyMan123 TheBunnyMan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is in fact code

@soup587 soup587 marked this pull request as draft December 19, 2024 12:58
@soup587
Copy link
Contributor Author

soup587 commented Dec 19, 2024

just realised i think this actually broke looped interpolation

@soup587
Copy link
Contributor Author

soup587 commented Dec 19, 2024

(it's not as noticeable as non-looped interpolation but like it should not breaked it)

@soup587 soup587 marked this pull request as ready for review December 19, 2024 13:25
@soup587
Copy link
Contributor Author

soup587 commented Dec 19, 2024

nvm it's not a regression. may still look into it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants