Add arrow hiding function #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Inject(method = "renderStuckItem", at = @At("HEAD"), cancellable = true) | ||
| private void disableStuckArrowsRendering(PoseStack matrices, MultiBufferSource vertexConsumers, int light, Entity entity, float directionX, float directionY, float directionZ, float tickDelta, CallbackInfo ci) { | ||
| Avatar avatar = AvatarManager.getAvatarForPlayer(FiguraMod.getLocalPlayerUUID()); |
There was a problem hiding this comment.
bad implementation, now the arrows' visibility for all players depends on the the setting of the avatar of the local player, not of their respective avatars
There was a problem hiding this comment.
yeah i fucked up and forgot to test mp, ill draft and work on fix
Riftlight
force-pushed
the
1.20ArrowFunc
branch
from
31eac47 to
fcd7878
Compare
|
as far as i can tell, everything is working. ill give myself a bit more time to test though because i dont trust myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to
RendererAPI,setRenderArrows, to control whether or not arrows stuck in the player are rendered. Adds an entry inen_us.jsonfor it and adds a mixin for it.