Accessing Animation Data #41
Conversation
There was a problem hiding this comment.
And overall, for future reference: you can just add more commits to the branch you are pulling from (github should be showing you the prompt "Add more commits by pushing to the 1.20 branch on Ovionyx/Figura.") and there is no need to close PR and re-open as a new one
| List<Animation.AnimationChannel> value = new ArrayList<Animation.AnimationChannel>(); | ||
| for (Animation.AnimationChannel channel : entry.getValue()) { | ||
| value.add(channel); | ||
| } |
There was a problem hiding this comment.
Is there any need to iterate over all channels instead of initializing the list with the collection?
| @@ -140,6 +141,25 @@ public void playCode(float minTime, float maxTime) { | |||
| // -- lua methods -- // | |||
|
|
|||
|
|
|||
| @LuaWhitelist | |||
| @LuaMethodDoc("animation.getChannels") | |||
| public LuaTable getChannels() { | |||
There was a problem hiding this comment.
I am guessing this is because it is called "channel" in BlockBench?
There was a problem hiding this comment.
its because thats what figura refers to them as (AnimationChannel)
| name = "AnimationChannel", | ||
| value = "animation_channel" | ||
| ) | ||
| public record AnimationChannel(TransformType type, Keyframe... keyframes) { |
There was a problem hiding this comment.
Oh, does @LuaWhitelist not work on record fields?
There was a problem hiding this comment.
i jsut forgot to add it i think
| public FiguraVec3 getTargetB(float delta) { | ||
| return targetB != null ? targetB.copy() : FiguraVec3.of(parseStringData(bCode[0], delta), parseStringData(bCode[1], delta), parseStringData(bCode[2], delta)); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Just an extra empty line?
|
|
||
| "figura.docs.keyframe.get_target_a": "Gets target 'A' of this keyframe\n I have no idea what 'A' means", | ||
| "figura.docs.keyframe.get_target_b": "Gets target 'B' of this keyframe\n I have no idea what 'B' means", | ||
| "figura.docs.keyframe.ph": "", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| @@ -83,26 +96,43 @@ private float parseStringData(String data, float delta) { | |||
| return FiguraMod.popReturnProfiler(0f); | |||
| } | |||
|
|
|||
| @LuaWhitelist | |||
| @LuaMethodDoc("keyframe.ph") | |||
There was a problem hiding this comment.
@LuaMethodDoc is not required for a function to be accessible in Lua, but if you are adding docs, please do it properly or remove useless "docs".
There was a problem hiding this comment.
From what i can tell thats required to have it show up in the docs command, they're all pretty self explanatory, so documentation shouldnt really be necessary imo
There was a problem hiding this comment.
"setPos" and "setRot" are also self-explanatory but still are documented, and it's better to have consistent documentation
| public Interpolation getInterpolation() { | ||
| return interpolation; | ||
| } | ||
|
|
||
| @LuaWhitelist | ||
| @LuaMethodDoc("keyframe.ph") | ||
| public String getInterpolate() { |
There was a problem hiding this comment.
Also, forgot about this, but getInterpolation (verb noun) not getInterpolate (verb verb)
There was a problem hiding this comment.
so uhhhh, that is different from the existing getInterpolation and idk how to get around that
waybe we should move to dev-chat
There was a problem hiding this comment.
having the same name is fine, maybe add a Void argument? or no, LuaValue arg? don't know which, but
i am physically unable to move to dev-chat
|
Could you please list the changes made as described in pr #42 |
(Note, currently missing documentation)
(Note, currently missing documentation)
No description provided.