Skip to content

Conversation

DarkLord017
Copy link
Contributor

@DarkLord017 DarkLord017 commented Oct 21, 2025

Resolves

#304

  • Added new error ExtraDataSizeExceeded in Errors.sol to signal when extraData exceeds allowed limits.
  • Defined new constants for maximum extra data sizes in FilecoinWarmStorageService.sol:
    • MAX_CREATE_DATA_SET_EXTRA_DATA_SIZE = 4 KiB
    • MAX_PIECES_ADDED_EXTRA_DATA_SIZE = 8 KiB
  • Updated functions in FilecoinWarmStorageService to:
    • Check extraData.length against these limits.
    • Revert with ExtraDataSizeExceeded if the size exceeds the maximum allowed.

Did not add tests as this adds only a require statement , le'me know will add tests as well

@FilOzzy FilOzzy added this to FS Oct 21, 2025
@github-project-automation github-project-automation bot moved this to 📌 Triage in FS Oct 21, 2025
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FS Oct 22, 2025
@rvagg
Copy link
Collaborator

rvagg commented Oct 22, 2025

some tests that push beyond the limits would be nice too, and lint and generate-abi please

@rjan90 rjan90 linked an issue Oct 22, 2025 that may be closed by this pull request
DarkLord017 and others added 2 commits October 22, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 Awaiting review

Development

Successfully merging this pull request may close these issues.

Implement EXTRA_DATA_MAX_SIZE Limit in Filecoin-Services

3 participants