Skip to content

Conversation

@jpkha
Copy link
Member

@jpkha jpkha commented Jan 28, 2026

Context

Briefly describe the purpose and context of this PR. Include relevant screenshots or screen recordings for the product team.

  • fix eslint error-boundaries and improve error logging
  • Handle properly frontend error in public path
  • Send frontend error to the back

How to test

Provide step-by-step instructions to test your changes. Include screenshots of your local testing results.

Related issues

Checklist

Quality

  • I consider this work complete and ready for review
  • I tested all features and edge cases
  • I refactored code where necessary to improve quality
  • I made sure my code meets development guidelines
  • I performed a self-review of my code

Testing

  • I wrote test cases for the relevant use cases (unit, integration or e2e tests)
  • (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

  • Unit tests
  • Integration tests
  • E2E tests
  • Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

@github-actions github-actions bot added the Filigran Team use to identify PR from the Filigran team label Jan 28, 2026
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 1.17647% with 252 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.85%. Comparing base (32c8cf3) to head (6a4eab0).
⚠️ Report is 2 commits behind head on development.

Files with missing lines Patch % Lines
...p/(public)/cybersecurity-solutions/[slug]/page.tsx 0.00% 104 Missing ⚠️
apps/portal-front/src/components/app-error.tsx 2.56% 38 Missing ⚠️
apps/portal-front/app/(application)/app/layout.tsx 0.00% 25 Missing ⚠️
.../portal-front/src/components/public-path-error.tsx 3.84% 25 Missing ⚠️
.../(public)/cybersecurity-solutions/[slug]/error.tsx 0.00% 20 Missing and 1 partial ⚠️
apps/portal-front/app/not-found.tsx 7.69% 12 Missing ⚠️
[...InstanceId]/subscription/[subscriptionId]/page.tsx](https://app.codecov.io/gh/FiligranHQ/xtm-hub/pull/1602?src=pr&el=tree&filepath=apps%2Fportal-front%2Fapp%2F%28application%29%2Fapp%2F%28user%29%2Fmanage%2Fservice%2F%5BserviceInstanceId%5D%2Fsubscription%2F%5BsubscriptionId%5D%2Fpage.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FiligranHQ#diff-YXBwcy9wb3J0YWwtZnJvbnQvYXBwLyhhcHBsaWNhdGlvbikvYXBwLyh1c2VyKS9tYW5hZ2Uvc2VydmljZS9bc2VydmljZUluc3RhbmNlSWRdL3N1YnNjcmlwdGlvbi9bc3Vic2NyaXB0aW9uSWRdL3BhZ2UudHN4) 0.00% 9 Missing ⚠️
...pp/(embed)/unregister/[identifier]/page-loader.tsx 0.00% 9 Missing ⚠️
...ortal-front/app/(application)/app/global-error.tsx 0.00% 4 Missing ⚠️
...rtal-front/app/(application)/app/(admin)/error.tsx 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1602      +/-   ##
===============================================
+ Coverage        28.83%   28.85%   +0.02%     
===============================================
  Files              614      617       +3     
  Lines            40368    40350      -18     
  Branches          2023     2026       +3     
===============================================
+ Hits             11641    11644       +3     
+ Misses           28457    28436      -21     
  Partials           270      270              
Files with missing lines Coverage Δ
...(admin)/admin/service/[slug]/subscription/page.tsx 0.00% <0.00%> (ø)
...rtal-front/app/(application)/app/(admin)/error.tsx 12.50% <0.00%> (+9.55%) ⬆️
...ortal-front/app/(application)/app/(user)/error.tsx 12.50% <0.00%> (+9.55%) ⬆️
...ortal-front/app/(application)/app/global-error.tsx 6.25% <0.00%> (+3.61%) ⬆️
[...InstanceId]/subscription/[subscriptionId]/page.tsx](https://app.codecov.io/gh/FiligranHQ/xtm-hub/pull/1602?src=pr&el=tree&filepath=apps%2Fportal-front%2Fapp%2F%28application%29%2Fapp%2F%28user%29%2Fmanage%2Fservice%2F%5BserviceInstanceId%5D%2Fsubscription%2F%5BsubscriptionId%5D%2Fpage.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FiligranHQ#diff-YXBwcy9wb3J0YWwtZnJvbnQvYXBwLyhhcHBsaWNhdGlvbikvYXBwLyh1c2VyKS9tYW5hZ2Uvc2VydmljZS9bc2VydmljZUluc3RhbmNlSWRdL3N1YnNjcmlwdGlvbi9bc3Vic2NyaXB0aW9uSWRdL3BhZ2UudHN4) 0.00% <0.00%> (ø)
...pp/(embed)/unregister/[identifier]/page-loader.tsx 0.00% <0.00%> (ø)
apps/portal-front/app/not-found.tsx 5.55% <7.69%> (+5.55%) ⬆️
.../(public)/cybersecurity-solutions/[slug]/error.tsx 0.00% <0.00%> (ø)
apps/portal-front/app/(application)/app/layout.tsx 1.81% <0.00%> (+0.42%) ⬆️
.../portal-front/src/components/public-path-error.tsx 3.84% <3.84%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c8cf3...6a4eab0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
31 31 0 0 0 0 3m 26s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
31 0 0 24.0s

Suites

31 passed, 0 failed, and 0 other

Suite Passed Failed Other Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts
        ✅ should prevent user to update another one when he does not have MANAGE_ACCESS
        ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION
        ✅ should allow user to update another one when he has MANAGE_ACCESS
✅ 3 ❌ 0 ⏭️ 0 5.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts
        ✅ Should add subscription with capabilities
✅ 1 ❌ 0 ⏭️ 0 24.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts
        ✅ Should add CSV Feed
        ✅ Should delete CSV Feed from the list
        ✅ Should delete CSV Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 20.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts
        ✅ Should add custom dashboard
        ✅ Should see the custom dashboard on public page
        ✅ Should edit a custom dashboard
✅ 3 ❌ 0 ⏭️ 0 28.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts
        ✅ should perform complete CRUD operations on documents
✅ 1 ❌ 0 ⏭️ 0 4.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts
        ✅ should send telemetry event
✅ 1 ❌ 0 ⏭️ 0 7.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts
        ✅ should perform complete CRUD operations on organizations
✅ 1 ❌ 0 ⏭️ 0 5.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts
        ✅ should update user profile information
✅ 1 ❌ 0 ⏭️ 0 4.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts
        ✅ should redirect user between public pages and login page
✅ 1 ❌ 0 ⏭️ 0 3.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts
        ✅ should register openAEV platform
        ✅ should register openCTI platform
✅ 2 ❌ 0 ⏭️ 0 6.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts
        ✅ should be able to admin service
✅ 1 ❌ 0 ⏭️ 0 9.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts
        ✅ should be able to add pictures to a service
✅ 1 ❌ 0 ⏭️ 0 4.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/streams.spec.ts
        ✅ Should add Stream
        ✅ Should delete Stream from the list
        ✅ Should delete Stream from the detailed page
✅ 3 ❌ 0 ⏭️ 0 22.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/taxii-feeds.spec.ts
        ✅ Should add TAXII Feed
        ✅ Should delete TAXII Feed from the list
        ✅ Should delete TAXII Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 21.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/third-party-integrations.spec.ts
        ✅ Should add Third Party Integration
        ✅ Should delete Third Party Integration from the list
        ✅ Should delete Third Party Integration from the detailed page
✅ 3 ❌ 0 ⏭️ 0 22.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts
        ✅ Should perform complete CRUD of users as BYPASS
        ✅ Should only see authorized users
        ✅ Should not edit first and last name as MANAGE_ACCESS user
✅ 3 ❌ 0 ⏭️ 0 16.4s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@jpkha jpkha merged commit 831016c into development Jan 29, 2026
17 checks passed
@jpkha jpkha deleted the issue/1592 branch January 29, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Filigran Team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants