Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map ft-content bodyxml nodes to content-tree nodes #50

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

chee
Copy link
Member

@chee chee commented Feb 15, 2024

previously we were only mapping <content/> nodes. which, arjun explains, is only what they are called before publishing. in the live bodyXML they are called <ft-content/>

when are these called `content`? i know it is sometimes
@chee chee requested a review from vbachev February 15, 2024 12:00
@chee chee requested review from a team as code owners February 15, 2024 12:00
@adgad
Copy link
Collaborator

adgad commented Feb 15, 2024

We call them <content> when we publish (for some reason?!) and then when it comes out of the other end it somehow gets turned into <ft-content>

I didn't think it should ever be <content> out of api.ft.com? unless maybe we're using it inside <experimental> anywhere....

@chee
Copy link
Member Author

chee commented Feb 15, 2024

We call them <content> when we publish (for some reason?!) and then when it comes out of the other end it somehow gets turned into <ft-content>

I didn't think it should ever be <content> out of api.ft.com? unless maybe we're using it inside <experimental> anywhere....

ahh, thanky ou

@epavlova
Copy link

We probably don't need to have ft-content node in the content tree. This is actually happening in the C&M world for some reason. This will probably go in the future logic to transform a tree to body XML.

@chee
Copy link
Member Author

chee commented Feb 15, 2024

We probably don't need to have ft-content node in the content tree. This is actually happening in the C&M world for some reason. This will probably go in the future logic to transform a tree to body XML.

ah, i think my title is probably confusing. this is only allowing the ft-content bodyxml nodes to be mapped to the correct content-tree node, i'll update the title to be more clear

@chee chee changed the title allow content nodes to be called ft-content map ft-content bodyxml nodes to content-tree nodes Feb 15, 2024
@chee chee merged commit 5ea3cfa into main Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants