Skip to content

Commit

Permalink
Merge pull request #1097 from Financial-Times/ADSDEV-2104-moat-deprec…
Browse files Browse the repository at this point in the history
…ation-remove-moat-ads-traffic-flag-and-ads-moat-timeout-from-the-codebase

ADSDEV-2104: Removing moatAdsTraffic flag
  • Loading branch information
fabioleiteparserft authored Nov 27, 2024
2 parents 7ebf08c + e669f43 commit cf60250
Show file tree
Hide file tree
Showing 4 changed files with 3,147 additions and 6,420 deletions.
7 changes: 1 addition & 6 deletions examples/kitchen-sink/client/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,7 @@ readyState.domready.then(async () => {
lazyLoadMargins: {
760: '15%',
980: '5%'
},
waitForMoat: true
}

if (flagsClient.get('moatAdsTraffic')) {
displayAds.validateTraffic?.()
}
}

// Fetch the ads data
Expand Down
2 changes: 1 addition & 1 deletion examples/kitchen-sink/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"test": "../../node_modules/.bin/jest"
},
"dependencies": {
"@financial-times/ads-display": "^5.2.8",
"@financial-times/ads-display": "^6.3.0",
"@financial-times/dotcom-middleware-app-context": "file:../../packages/dotcom-middleware-app-context",
"@financial-times/dotcom-middleware-asset-loader": "file:../../packages/dotcom-middleware-asset-loader",
"@financial-times/dotcom-middleware-navigation": "file:../../packages/dotcom-middleware-navigation",
Expand Down
1 change: 0 additions & 1 deletion examples/kitchen-sink/server/controllers/home.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const flagsStore = {
tracking: true,
oTracking: true,
AdsPermutive: true,
moatAdsTraffic: true,
adsEnableTestCreatives: false
}

Expand Down
Loading

0 comments on commit cf60250

Please sign in to comment.