Skip to content

Commit

Permalink
Remove the Node.js version healthcheck
Browse files Browse the repository at this point in the history
There's no need for this to be an operational alert. This is covered
well by several Problem Hub problems and I prefer the code we don't have
to maintain.
  • Loading branch information
rowanmanning committed Aug 21, 2024
1 parent f344a33 commit 8dddb67
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 125 deletions.
13 changes: 9 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
"express": "^4.17.3",
"isomorphic-fetch": "^3.0.0",
"n-health": "^13.0.0",
"next-metrics": "^12.15.0",
"semver": "^7.3.7"
"next-metrics": "^12.15.0"
},
"devDependencies": {
"@dotcom-tool-kit/component": "^4.0.4",
Expand Down
4 changes: 1 addition & 3 deletions src/lib/health-checks.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
const logger = require('@dotcom-reliability-kit/logger');

const metricsHealthCheck = require('./metrics-healthcheck');
const supportedNodeJsVersionCheck = require('./supported-node-js-version-check');

/**
* @param {ExpressApp} app
Expand All @@ -32,8 +31,7 @@ module.exports = (app, options, meta) => {
/** @type {Healthcheck[]} */
const defaultChecks = [
...tickingMetricChecks,
metricsHealthCheck(meta.name),
supportedNodeJsVersionCheck(meta.name)
metricsHealthCheck(meta.name)
];

/** @type {Healthcheck[]} */
Expand Down
51 changes: 0 additions & 51 deletions src/lib/supported-node-js-version-check.js

This file was deleted.

65 changes: 0 additions & 65 deletions test/app/supported-node-js-version-check.test.js

This file was deleted.

0 comments on commit 8dddb67

Please sign in to comment.