Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Update image for alpine and fixed small bug with fuse library path #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FrenchBen
Copy link

Alpine is just much smaller and easier to work with - The resulting image size is ~61mb compared to ~473 MB for the Phusion base image.

Regarding the fuse.py patch, more details can be found here:
https://github.com/terencehonles/fusepy/issues/35#issuecomment-147133806


This change is Reviewable

@bubenkoff
Copy link
Contributor

Thanks for the contribution!
But this repo's idea has a bigger issue in general - it's simply not possible to export a mount from the container. I realized that after i made a release :). Just curious how useful this docker image is for you?


Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


Dockerfile, line 9 [r1] (raw file):
i'd use at least a package installed directly from some commit/feature branch, instead of keeping the patch directly in this repo


Comments from the review on Reviewable.io

@FrenchBen
Copy link
Author

Regarding the patch, it would be ideal, unfortunately it's pending as a comment right now, thus the patch seemed like the easy way to go about it.

I'll have to do some testing, but I'm unsure what the issue is? Shouldn't a mount be a simple drive/folder endpoint and thus you can export it using the regular VOLUME and VOLUME_FROM - I can deploy my patch and see what it looks like?

@bubenkoff
Copy link
Contributor

this image DOES mount the s3 folder fine, that's not the concern, but there's no way you can use that mount from other containers, as volume_from would use just an fs folder from container, and NOT the s3 folder contents.
You can check that yourself.

@FrenchBen
Copy link
Author

I see - I missed that part. This current patch seems to break anyway, as I get the dreaded SSL: CERTIFICATE_VERIFY_FAILED that some aws-cli users have reported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants