Skip to content

[RELEASE] 데모데이를 위한 기능 제한 배포 #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeonbinggu merged 4 commits into from
Feb 20, 2026
Merged

[RELEASE] 데모데이를 위한 기능 제한 배포 #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abd91d5
feat: 데모데이용 기능 제한(#263)
dodaaaaam Feb 20, 2026
ac29742
Merge pull request #265 from Finders-Official/feat/photo-manage-demov…
dodaaaaam Feb 20, 2026
ba58a73
refactor: 폰트 변경(#264)
jeonbinggu Feb 20, 2026
631781f
Merge pull request #266 from Finders-Official/refactor/ydestreet(#264)
jeonbinggu Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added src/assets/fonts/YdestreetB.woff2
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@

@font-face {
font-family: Ydestreet;
src: url("./assets/fonts/YdestreetL.woff2") format("woff2");
src: url("./assets/fonts/YdestreetB.woff2") format("woff2");
font-weight: 700;
}

Expand Down
15 changes: 7 additions & 8 deletions src/pages/photoManage/PhotoManageMainPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { getActiveStatus } from "@/utils/getActiveStatus";
import { STATUS_INDEX_MAP } from "@/constants/photomanage/status.constant";
import { getBannerContent } from "@/lib/getBannerContent";
import { usePrintOrderStore } from "@/store/usePrintOrder.store";
import { usePrintSkip, useConfirmReceipt } from "@/hooks/photoManage";
// import { usePrintSkip, useConfirmReceipt } from "@/hooks/photoManage";
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

사용하지 않는 임포트를 주석 처리로 남겨두기보다 삭제하는 것이 깔끔합니다. 필요한 경우 나중에 Git 히스토리에서 확인하거나 복구할 수 있습니다.


export default function PhotoManageMainPage() {
const navigate = useNavigate();
Expand Down Expand Up @@ -50,11 +50,11 @@ export default function PhotoManageMainPage() {
queryFn: getCurrentWork,
});

// 인화 안 함 확정
const { mutate: printSkip } = usePrintSkip();
// 인화 안 함 확정 - 데모데이용에서는 제거
// const { mutate: printSkip } = usePrintSkip();

// 수령 확정
const { mutate: confirmReceiptMutate } = useConfirmReceipt();
// 수령 확정 - 데모데이용에서는 제거
// const { mutate: confirmReceiptMutate } = useConfirmReceipt();
Comment on lines +54 to +57
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

기능 제한을 위해 훅 호출을 주석 처리하셨습니다. 주석 처리된 코드는 유지보수 시 혼란을 줄 수 있으므로 삭제를 권장하며, 기능 제어가 빈번하다면 피처 플래그나 환경 변수를 활용하는 것이 더 체계적인 방법입니다.


const workData = currentWorkResponse?.data;
const setDevelopmentOrderId = usePrintOrderStore(
Expand Down Expand Up @@ -90,8 +90,7 @@ export default function PhotoManageMainPage() {
}),
onGoFeed: () => navigate("/photoFeed"),
onGoTrackDelivery: () => {},
onConfirmReceived: () =>
confirmReceiptMutate(workData.developmentOrderId),
onConfirmReceived: () => {},
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

콜백을 빈 함수로 설정하면 사용자가 버튼을 클릭했을 때 아무런 피드백을 받지 못해 시스템 오류로 오해할 수 있습니다. 기능을 제한하려는 의도라면 해당 버튼이 노출되지 않도록 처리하거나, 클릭 시 안내 메시지를 제공하는 것이 좋습니다.

})
: [];

Expand Down Expand Up @@ -181,7 +180,7 @@ export default function PhotoManageMainPage() {
if (dialogStep === 1) setDialogStep(2);
else {
setIsDialogOpen(false);
printSkip(workData.developmentOrderId);
//printSkip(workData.developmentOrderId);
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

주석 처리된 실행 코드는 삭제하는 것이 좋습니다. 코드의 의도를 명확히 하기 위해 주석 대신 로직 자체를 제거하거나 적절한 처리를 추가해 주세요.

}
}}
/>
Expand Down