Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying stacks on machines that are either slow/low resource or have slow internet connection, the deployment step often takes longer than 10 seconds. When that happens the deploy progress popover will show an error
TypeError: Error in input stream.This happens because the connection to
deploy-streamendpoint gets eventually timed out either by any proxies in between or bun as it uses the default IDLE_TIMEOUT env var value of 10 seconds. Then the response reader errors out and produces the errorTypeError: Error in input stream.This PR adds a heartbeat to the deploy-stream API that fires every 5 seconds. The frontend will filter it out as the actual message doesn't start with
data:. As such this is purely to keep the connection open and doesn't change or add anything visible to the user. The implementation is very similar to how e.g. merged-logs API already does it.Additionally the hawser edge requests' timeout has been extended from 30 seconds to 2 minutes (when non-streaming). 30 seconds in mentioned scenarios is not enough and the popover would show error
Connection timeout. 2 minutes is something that worked in my scenario, but happy to change to a more optimal value if needed.I think this potentially addresses #329