Add --build flag for git stack deploys#472
Open
TimElschner wants to merge 1 commit intoFinsys:mainfrom
Open
Conversation
Contributor
|
@TimElschner can you please remove claude from commits - we don't want Claude to be contributor in Dockhand. :) |
Git stack deploys via webhook/auto-update were missing the --build flag, so containers with build: directives never rebuilt on code changes. Adds a per-stack "Build images on deploy" toggle (default: true) that passes --build to docker compose up through the entire deploy chain including Hawser remote agents.
a38ed69 to
2173e27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
true) sodocker compose upincludes--buildwhen deploying git stacks via webhook, auto-update, or manual deploybuild:directives in their compose file were recreated from cached images — code changes were never deployeddeployGitStack→deployStack→executeComposeCommand→executeLocalCompose/executeComposeViaHawserChanges
schema/index.ts,schema/pg-schema.tsbuild_on_deploycolumn (default true)drizzle/0004_*,drizzle-pg/0004_*db.tsGitStackData,createGitStack,updateGitStackstacks.ts--buildin compose args + Hawser JSON bodygit.tsdeployGitStackanddeployGitStackWithProgressapi/git/stacks/+server.ts,[id]/+server.tsbuildOnDeployGitStackModal.sveltetests/stack-git-flow.test.tsNon-git stacks are unaffected
The
buildoption only flows through whenDeployStackOptions.buildis explicitly set. Git stacks read it fromgitStack.buildOnDeploy; all other stack types leave itundefined→ no--buildflag.Test plan
buildOnDeploy: truein responsebuildOnDeploy: falsepersistsbuild:in compose file → verify--buildappears in compose commandbuildOnDeploy: false→ verify--buildis absent--buildflag (no regression)build: true🤖 Generated with Claude Code