Skip to content

Comments

C Mode, Japanese version support and testing inline assembly#6

Open
laqieer wants to merge 43 commits intoFireEmblemUniverse:masterfrom
laqieer:master
Open

C Mode, Japanese version support and testing inline assembly#6
laqieer wants to merge 43 commits intoFireEmblemUniverse:masterfrom
laqieer:master

Conversation

@laqieer
Copy link

@laqieer laqieer commented Dec 3, 2019

Read README3.md for more info.

@Crazycolorz5
Copy link
Member

I'm sorry, this is a lot of changes.

Could you briefly describe what changes have taken place? It seems like a lot of files were moved, possibly?

Should this really be merged into master, as opposed to be put on its own feature branch?

@StanHash Do you have any opinions or anything to add?

@laqieer
Copy link
Author

laqieer commented Dec 3, 2019

I'm sorry, this is a lot of changes.

Could you briefly describe what changes have taken place? It seems like a lot of files were moved, possibly?

Should this really be merged into master, as opposed to be put on its own feature branch?

@StanHash Do you have any opinions or anything to add?

3 new features as described in the title. It accepts new command line argument. Though it is lots of changes, all changes are in the standalone new mode, which compiles event scripts to assembly source files. I think it is okay to merge into the master branch because it doesn't affect the original functions. You can test whether old functions work before merging.

@StanHash
Copy link
Member

StanHash commented Dec 4, 2019

This looks like this originated from a fork of a different version of the Event Assembler source (probably one of the original Nintenlord sources) and the progress from that was just dumped in here. Which makes this PR a big git mess, adding a lot of unused source files as well as one big unnecessary doc dump.

Here is a list of files that have been added while not being referenced in the Core project (this may be inaccurate/incomplete, as I just made this quickly by hand):

Code\Preprocessors\Directives\IncludeExternal.cs
Code\Preprocessors\OldPrprocessor.cs
Code\Preprocessors\RegexPreprocessor.cs
Code\Preprocessors\ContextPreprocessor.cs
Code\Preprocessors\StringReplacers\NewReplacer.cs
Code\Preprocessors\StringReplacers\OriginalReplacer.cs
Code\Preprocessors\StringReplacers\IStringReplacer.cs
Code\Preprocessors\OldPreprocessor2.cs
Code\Language\Parser\StatementParser.cs
Code\Language\Parser\TokenParser.cs
Code\Language\Types\IntegerRepresentations\IntRepresentation.cs
Code\Language\Types\IntegerRepresentations\IIntegerType.cs
Code\Language\Assembly\AssemblyContext.cs
Code\Language\Assembly\EAExpressionAssembler.cs
Code\Language\Expression\Tree\Assingment.cs
Code\Language\Expression\Tree\MathOperators\Sum.cs
Code\Language\Expression\Tree\MathOperators\BitwiseOr.cs
Code\Language\Expression\Tree\MathOperators\BitwiseXor.cs
Code\Language\Expression\Tree\MathOperators\Division.cs
Code\Language\Expression\Tree\MathOperators\BitShiftRight.cs
Code\Language\Expression\Tree\MathOperators\Minus.cs
Code\Language\Expression\Tree\MathOperators\BinaryOperator.cs
Code\Language\Expression\Tree\MathOperators\BitShiftLeft.cs
Code\Language\Expression\Tree\MathOperators\Multiply.cs
Code\Language\Expression\Tree\MathOperators\BitwiseAnd.cs
Code\Language\Expression\Tree\MathOperators\Modulus.cs
Code\Language\Expression\Tree\ExpressionList.cs
Code\Language\Expression\Tree\Symbol.cs
Code\Language\Expression\Tree\Code.cs
Code\Language\Expression\Tree\Scope.cs
Code\Language\Expression\Tree\ValueExpression.cs
Code\Language\Expression\Tree\LabeledExpression.cs
Code\Language\Expression\IExpression.cs
Code\Language\Old\FE8CodeLanguage.cs
Code\Language\Old\BuiltInCodes\ScopeStarter.cs
Code\Language\Old\BuiltInCodes\Printer.cs
Code\Language\Old\BuiltInCodes\IBuiltInCode.cs
Code\Language\Old\BuiltInCodes\ScopeEnder.cs
Code\Language\Old\BuiltInCodes\OffsetChanger.cs
Code\Language\Old\BuiltInCodes\OffsetAlinger.cs
Code\Language\Old\FE7CodeLanguage.cs
Code\Language\Old\EACodeLanguage.cs
Code\Language\Old\FE6CodeLanguage.cs
Code\Language\Old\Priority.cs
Code\Language\Old\EACodeLanguageAssembler.cs
Code\Language\ICodeLanguage.cs
Code\Templates\GenericFE8Ender.cs
Code\Templates\GenericFE8Template.cs
IO\Input\CommandLineArgs.cs
IO\Input\InputByteStream.cs
Collections\DefineCollectionTreeBased.cs
Collections\DefineCollectionOld.cs
Collections\DefineCollection.cs

It is up to Colorz whether we care or not for this to become even more of a mess than this already is. If it were up to me I would request this to be cleaned up before considering anything else.

When it comes to the added features themselves I don't see any real reason to deny their inclusion (although I would like to know what was actually added/changed which is hard to do with the branch in its current state).

@laqieer
Copy link
Author

laqieer commented Dec 5, 2019

Most of the file changes are from commit 1523c7f, which are useless. I forget the reason why I need those source files to build at first.

@laqieer
Copy link
Author

laqieer commented Feb 11, 2020

The clean up is already done.

@laqieer laqieer force-pushed the master branch 2 times, most recently from b5ce680 to 485da02 Compare September 12, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants