Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite nginx code to use go-lib as the client #14

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Rewrite nginx code to use go-lib as the client #14

merged 6 commits into from
Feb 21, 2024

Conversation

muhammadn
Copy link
Collaborator

@muhammadn muhammadn commented Feb 19, 2024 •
edited
Loading

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have resolved any merge conflicts
  • I have run tests locally and they pass
  • I have linted and auto-formatted the code
  • If there is new or changed functionality, I have added/updated the tests.
  • If there is new or changed functionality, I have added/updated the documentation.

@muhammadn muhammadn mentioned this pull request Feb 19, 2024
Closed
5 tasks
@muhammadn
Copy link
Collaborator Author

@rileyfiretail @TheTeaCat Done. This uses Go library as client.

@TheTeaCat TheTeaCat changed the base branch from main to go-validation February 19, 2024 15:54
@muhammadn
Code cleanup
c9d53f9 
* Remove CURL dead code
* Enhance code readability with naming of arguments
@muhammadn muhammadn merged commit 7dd8992 into go-validation Feb 21, 2024
1 check passed
@muhammadn muhammadn deleted the feat/port-to-use-go-lib-client branch February 21, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@muhammadn