Go validation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I took a look here: https://github.com/helmut-jacob/jsonschema-c Unfortunately the implementation is very old. So i see, you are going to call Go function from C via FFI? |
|
Yeah, we've got a Go library here: https://github.com/FireTail-io/firetail-go-lib I'm going to try and make use of the middleware func there. |
* add changes to load spec in c * finish up code end of the day * fix lint errors for firetail module * Add Request Validation and Code Cleanup * Cleanup unused code to avoid all the noise * Add Request Validation * lint * curl cleanups and change firetail backend url to prod * lint (again) * write code for request * Format * Add /profile/alice and bob * Initial docs for request and response validation * buffer header and response * commit working code * lint * small fixes * last commit of the day * formatting * formatting * set original variable declaration * fix malformed request caused by premature kNextResponseBodyFilter * revert dockerfile to stable nginx release, update go.sum * fix all other methods in request handlers like POST/PUT/PATCH/etc.. * fix lint issues * Add post comment & proxy endpoint * use real method name for request/response * add response from /profile/bob to readme * fix code styling * Format * Fix some crossed wires in ValidateRequestBody * complete with request validation * remove debug code * Mark comment property as required in appspec * add header validation * fix styling * fix styling again * remove commented code from go lib * code cleanups * more cleanups * rewrite some code * Major fixes * Fixed a bug where the REQUEST validation was bypassed with a POST request without a body * Added validation for request headers * fix lint issues * should be in access phase and not preaccess phase * ignore vim files * fix a bug where a valid request get an incorrect response * proper naming of functions * fix lint issues * add missing proxy path that should be there * update appspec * fix a bug where GET requests cause nginx to crash * fix lint * Cleanups and removal old request filter code * fix lint issues * Remove some dead code * Doc request validation * Disable nginx debug logging --------- Co-authored-by: theteacat <joshua@firetail.io>
muhammadn
force-pushed
the
go-validation
branch
from
e03c734 to
c086e38
Compare
Switch to use official Go Library
* Rewrite the nginx module to use the Go library as the client. * Use a defined URL for firetail backend in nginx configuration
TheTeaCat
commented
Feb 22, 2024
rileyfiretail
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.