refactor(pag): Use fallocate as the primary method for extending a file
#8758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file - This should eliminate double writes of pages when file is extended. - If fallocate is not supported by filesystem fallback to the old method of writing zeroes to the file.
AlexPeshkoff
requested changes
Sep 29, 2025
asfernandes
reviewed
Sep 30, 2025
AlexPeshkoff
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore gets the biggest performance boost from this patch. I tested restore on a database with one table
CREATE TABLE TAB1(V1 VARCHAR(25), V2 VARCHAR(25), V3 VARCHAR(25), V4 VARCHAR(25)), with a file size of about 16 GB. The testing was done on two different PCs with the same OS (Ubuntu 24.04):Intel Core i5-10400 + WD Red SN700 1000 GB (111150WD): +10% speedup with-par 8;Ryzen 7 7700 + KINGSTON SKC3000S1024G (EIFK31.6): +18% speedup with-par 8;On Windows, the performance improvement is small (about 3-5%), so the real target of this patch is Linux.