2555 Add support for multiple valuesets and system filters to ValueSetExpander #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Hl7.Fhir.STU3/Specification/Terminology/ValueSetExpander.cs # src/Hl7.Fhir.Specification.STU3.Tests/Source/TerminologyTests.cs
…specified in the spec. - Using more delayed processing, so processing valuesets that are too big is actually stopped before attempting it. - Documented all steps more clearly, referring to the spec. - specifying both System and ValueSet will now do an intersection.
|
Note: this PR only contains the changes for STU3, for ease of review. PR #2559 will make sure this functionality also exists for R4+, but doing that in this PR would make reviewing hard due to reorganizations in the directory structure. TL;DR: first review this PR, then 2559 and if both are ok, merge this one first, then 2559. |
ewoutkramer
commented
Aug 2, 2023
src/Hl7.Fhir.Shims.STU3AndUp/Specification/Terminology/ValueSetExpander.cs
Show resolved
Hide resolved
mmsmits
requested changes
Aug 3, 2023
| { | ||
| if (inclusionChain.Contains(uri)) | ||
| throw new TerminologyServiceException($"ValueSet expansion encountered a cycling dependency from {inclusionChain.Peek()} back to {uri}."); |
There was a problem hiding this comment.
Ah, I was wondering how you would solve this, nice
mmsmits
approved these changes
Aug 3, 2023
|
fixes #2555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expander now supports having more than one valueset in an include and specifying a valueset + system to limit the import of said valuesets.
Also reworked the expander to more closely follow the expansion algorithm specified in the spec.