Harden delete-index, Add check

Firesphere · Oct 19, 2023 · 136e7b2 · 136e7b2
1 parent bcd9725
commit 136e7b2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Indexes/ElasticIndex.php b/src/Indexes/ElasticIndex.php
@@ -99,7 +99,7 @@ public function init()
      * @throws NotFoundExceptionInterface
      * @throws ServerResponseException
      */
-    public function deleteIndex(?HTTPRequest $request = null): bool
+    public function deleteIndex(HTTPRequest $request): bool
     {
         $deleteResult = false;
         if ($this->shouldClear($request) && $this->indexExists()) {

diff --git a/tests/unit/Tasks/ElasticIndexTaskTest.php b/tests/unit/Tasks/ElasticIndexTaskTest.php
@@ -35,6 +35,11 @@ public function testRun()
         $request = new HTTPRequest('GET', 'dev/tasks/ElasticIndexTask');
         $result = $task->run($request);
 
+        $this->assertGreaterThan(0, $result);
+        $this->assertinstanceOf(ElasticIndex::class, $task->getIndex());
+        $request = new HTTPRequest('GET', 'dev/tasks/ElasticIndexTask', ['clear' => true]);
+        $result = $task->run($request);
+
         $this->assertGreaterThan(0, $result);
         $this->assertinstanceOf(ElasticIndex::class, $task->getIndex());
     }