Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW-5023 Use new contact-us API #165

Merged
merged 2 commits into from
Oct 20, 2023
Merged

FW-5023 Use new contact-us API #165

merged 2 commits into from
Oct 20, 2023

Conversation

NolanVH
Copy link
Contributor

@NolanVH NolanVH commented Oct 17, 2023

Description of Changes

This PR re-enables the contact-us widget and form using the new contact-us API.

If the user is not logged in the form fields will be hidden and text prompting the user to log in will be shown.

The edit/create widget pages will now show the list of addresses that the contact form will send emails to, as well as some text informing the user to contact support if they would like to update the list.

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@NolanVH NolanVH marked this pull request as ready for review October 17, 2023 22:16
'We have encountered an unexpected error. Please report this to our Help Desk.',
})
break
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need these error messages somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The useMutationWithNotification dataHook will display a message and will also display the error sent from the backend. I believe it will display the following: "ERROR: Your email was NOT sent. {backend message}. Please try again. If the error persists please contact FirstVoices Support."

I would be happy to customize the error messages if needed.

Copy link
Contributor

@sahil97 sahil97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@NolanVH NolanVH force-pushed the fw-5023-use-contact-us-api branch from 70192a9 to 972e5a9 Compare October 20, 2023 16:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@NolanVH NolanVH merged commit 0fab983 into main Oct 20, 2023
4 checks passed
@NolanVH NolanVH deleted the fw-5023-use-contact-us-api branch October 20, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants