Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FW-4672 FE media search hookup #171

Merged
merged 7 commits into from
Oct 26, 2023
Merged

FW-4672 FE media search hookup #171

merged 7 commits into from
Oct 26, 2023

Conversation

sahil97
Copy link
Contributor

@sahil97 sahil97 commented Oct 24, 2023 •
edited
Loading

Description of Changes

Refactored media search components to use new APIs

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@sahil97 sahil97 changed the title refactored MediaBrowserContainer to use the new APIs FW-4672 FE media search hookup Oct 24, 2023
@sahil97 sahil97 marked this pull request as ready for review October 25, 2023 20:42
gmcauliffe
gmcauliffe approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@gmcauliffe gmcauliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great conversion. This feature is going to be a huge time saver for Language Teams!

I've added some small suggestions around use of constants. Let me know if you want to chat about it.

src/components/DashboardMedia/DashboardMediaData.js Outdated Show resolved Hide resolved
src/common/utils/stringHelpers.js Outdated Show resolved Hide resolved
src/components/DashboardMedia/DashboardMediaData.js Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sahil97 sahil97 merged commit 78d785b into main Oct 26, 2023
4 checks passed
@sahil97 sahil97 deleted the FW-4672-fe-media-search-hookup branch October 26, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcauliffe gmcauliffe gmcauliffe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahil97 @gmcauliffe