Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix size logic in LazyImage #178

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix size logic in LazyImage #178

merged 1 commit into from
Oct 26, 2023

Conversation

gmcauliffe
Copy link
Contributor

Description of Changes

Lazy image was returning MEDIUM when ORIGINAL was needed

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@gmcauliffe
Update LazyImage.js
d1ce8bb 
Lazy image was returning MEDIUM when ORIGINAL was needed
@gmcauliffe gmcauliffe marked this pull request as ready for review October 26, 2023 19:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gmcauliffe gmcauliffe changed the title Update LazyImage.js Fix size logic in LazyImage Oct 26, 2023
@gmcauliffe gmcauliffe merged commit 3f86c78 into main Oct 26, 2023
@gmcauliffe gmcauliffe deleted the fix-lazy-image branch October 26, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahfirstvoices sarahfirstvoices sarahfirstvoices approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmcauliffe @sarahfirstvoices