Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fw-5179, fix refresh error #185

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fw-5179, fix refresh error #185

merged 1 commit into from
Nov 7, 2023

Conversation

sarahfirstvoices
Copy link
Contributor

Description of Changes

  • Move NavBar home buttons into loading container
  • Ensure siteLoading is false until siteStore is ready

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@sarahfirstvoices
fw-5179, fix refresh error
76ab651 
* Move NavBar home buttons into loading container
* Ensure siteLoading is false until siteStore is ready
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sahil97
sahil97 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@sahil97 sahil97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. LGTM !

@sarahfirstvoices sarahfirstvoices merged commit 60c3bd6 into main Nov 7, 2023
4 checks passed
@sarahfirstvoices sarahfirstvoices deleted the fw-5179-refresh-error branch November 7, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmcauliffe gmcauliffe gmcauliffe approved these changes

@sahil97 sahil97 sahil97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahfirstvoices @sahil97 @gmcauliffe