Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FW-1818, FW-3934 list view for join requests and admin approve and ignore #187

Merged
merged 13 commits into from
Nov 9, 2023
Merged

FW-1818, FW-3934 list view for join requests and admin approve and ignore #187

merged 13 commits into from
Nov 9, 2023

Conversation

gmcauliffe
Copy link
Contributor

Description of Changes

  • added list view for join requests to Dashboard homepage for Language Admins
  • added approve and ignore buttons to list
  • added ability to assign role when approving
  • added expandable info to show reasons and message from user for request

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@gmcauliffe gmcauliffe marked this pull request as ready for review November 9, 2023 19:21
NolanVH
NolanVH approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@NolanVH NolanVH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me! Tested locally and everything is working as expected. The new admin join request UI is looking great!

@gmcauliffe gmcauliffe merged commit ababdd7 into main Nov 9, 2023
4 checks passed
@gmcauliffe gmcauliffe deleted the FW-1818-list-view-for-join-requests branch November 9, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NolanVH NolanVH NolanVH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmcauliffe @NolanVH