Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW-3856-beta-sign #193

Merged
merged 2 commits into from
Nov 16, 2023
Merged

FW-3856-beta-sign #193

merged 2 commits into from
Nov 16, 2023

Conversation

Cara-Barter
Copy link
Contributor

Description of Changes

added missing https:// as well as added button to other navbar

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

Copy link
Contributor

@NolanVH NolanVH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me. I have added one optional minor comment. Thanks @Cara-Barter!

src/components/NavBar/NavBarPresentation.js Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Cara-Barter Cara-Barter merged commit ce72ee4 into main Nov 16, 2023
4 checks passed
@Cara-Barter Cara-Barter deleted the FW-3856-beta-sign branch November 16, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants