Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW-4809 Reduce visibility options for assistant create #205

Merged

Conversation

NolanVH
Copy link
Contributor

@NolanVH NolanVH commented Nov 22, 2023

Description of Changes

This PR reduces the number of visibility options displayed for an assistant on the words/phrases/songs/stories create pages. This is to prevent the error case from being possible as an assistant cannot create items with visibility other than "team".

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@NolanVH NolanVH force-pushed the FW-4809-assistant-dashboard-create-visibility-options-reduction branch from 5ee5c5e to a2e6c0f Compare November 22, 2023 21:57
Copy link
Contributor

@sahil97 sahil97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@NolanVH NolanVH force-pushed the FW-4809-assistant-dashboard-create-visibility-options-reduction branch from 148f514 to 1ef118a Compare November 22, 2023 23:03
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@NolanVH NolanVH merged commit 379836a into main Nov 23, 2023
4 checks passed
@NolanVH NolanVH deleted the FW-4809-assistant-dashboard-create-visibility-options-reduction branch November 23, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants