Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW-5751 update site app page part 1 #589

Merged
merged 15 commits into from
Sep 11, 2024
Merged

Conversation

gmcauliffe
Copy link
Contributor

@gmcauliffe gmcauliffe commented Sep 9, 2024

Description of Changes

  • decoupled site Keyboards and Apps pages
  • switched over to generated paths used for WidgetApps
  • Updated copy on Apps page and apps widget

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@gmcauliffe gmcauliffe marked this pull request as ready for review September 11, 2024 19:03
Copy link

<p>
Many languages have alphabets with letters that are not available on the standard English keyboard. To type
these letters, you must install a keyboard that will render characters in your Indigenous language. When the{' '}
{title} keyboard is installed on a computer, mobile phone or tablet, you will be able to type using your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these variables formatted right? The {' '} looks strange

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, It just ensures a space is maintained in the text before the inline variable {title} . There are a few different ways to achieve it of course but this is one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmcauliffe gmcauliffe merged commit 6488f15 into dev Sep 11, 2024
8 checks passed
@gmcauliffe gmcauliffe deleted the FW-5751-update-site-app-page branch September 11, 2024 22:19
sarahfirstvoices added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants