Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FW-5197 Part 1 - Separate Video Selector from Image Selector #598

Merged
merged 9 commits into from
Sep 17, 2024
Merged

FW-5197 Part 1 - Separate Video Selector from Image Selector #598

merged 9 commits into from
Sep 17, 2024

Conversation

gmcauliffe
Copy link
Contributor

@gmcauliffe gmcauliffe commented Sep 16, 2024 •
edited
Loading

Description of Changes

  • Renaming of Selector components to use convention Selector{type}
  • Break SearchSelector down into bite-size components to allow for easier reuse and less conditional logic.

Checklist

  • README / documentation has been updated if needed
  • PR title / commit messages contain Jira ticket number if applicable
  • Tests have been updated / created if applicable

Reviewers Should Do The Following:

  • Review the changes here
  • Pull the branch and test locally

Additional Notes

N/A

@gmcauliffe gmcauliffe changed the title FW-5197 Separate Video Selector from Image Selector FW-5197 Part 1 - Separate Video Selector from Image Selector Sep 16, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gmcauliffe gmcauliffe marked this pull request as ready for review September 16, 2024 17:02
sahil97
sahil97 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@sahil97 sahil97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@gmcauliffe gmcauliffe merged commit 0a8f2df into dev Sep 17, 2024
8 checks passed
@gmcauliffe gmcauliffe deleted the FW-5197-add-shared-image-results-to-the-image-selector branch September 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil97 sahil97 sahil97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmcauliffe @sahil97