FW-6190 clear media selection after adding #632
Conversation
|
| @@ -82,6 +84,7 @@ const { array, bool, func, node, object, oneOf } = PropTypes | |||
|
|
|||
| AddMediaModalWrapper.propTypes = { | |||
| selectedMedia: array, | |||
| setSelectedMedia: func, | |||
There was a problem hiding this comment.
I don't think we should expose both selectedMedia and setSelectedMedia as parameters, because it introduces a confusing duplication about how to set the selected media.
| @@ -26,6 +27,7 @@ function AddMediaModalWrapper({ | |||
| // allowing user to attach the selected/uploaded files to the document. | |||
| const handleOnClick = () => { | |||
| if (tabHasSelectedItems) updateSavedMedia(selectedMedia) | |||
| setSelectedMedia([]) | |||
There was a problem hiding this comment.
I think there is a bigger problem here than how we handle switching tabs. It appears that the selector is not distinguishing between the full list of selected items (the value of the form control) and the list of items that are currently selected in the modal. Looks like this affects the EntryArrayField as well.
I'm going to need to think about this a bit to figure out the best place to adjust this.
|
Solved in #647. |
Description of Changes
Checklist
README / documentation has been updated if neededTests have been updated / created if applicableReviewers Should Do The Following:
Pull the branch and test locallyAdditional Notes
N/A