Conversation
myqewr
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
WebClient를 사용해 카카오 서버로 인증을 수행하고 api 요청, 응답 과정을 수행하도록 구성🔍 참고사항
HttpServletRequest,HttpServletResponse,HttpSession등 HTTP 관련 객체가 application 계층까지 전달되면 계층 간 책임이 흐려지고 application 계층이 웹 프레임워크에 종속되기 때문에 클린 아키텍처에서는 HTTP 관련 객체가 내부 계층까지 전달되는 것을 지양한다고 합니다. 그래서HttpServletRequest,HttpServletResponse,HttpSession등 HTTP 관련 객체가 application 계층까지 전달되지 않도록KakaoLoginController에서 직접 infrastructure 계층의AuthenticationService를 주입받아 비즈니스 로직에는 관여하지 않고 기술적인 로직만을 처리할 수 있도록 했습니다. 이 방법이 확실하진 않지만 클린 아키텍처에 대해 공부하면서 추후 아키텍처를 리팩토링하면서 재설계 하도록 하겠습니다. 일반 로그인 로직도 리팩토링할 예정입니다 !📚 기타