fix UseRollingDevLogManifestFiles defaults

FizzCodeSoftware · Jan 18, 2024 · 0fa2d11 · 0fa2d11
1 parent 557a9fb
commit 0fa2d11
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/EtLast.ConsoleHost/ConsoleHost.cs b/EtLast.ConsoleHost/ConsoleHost.cs
@@ -1,4 +1,5 @@
 using FizzCode.EtLast.HostBuilder;
+using static FizzCode.EtLast.ConsoleHostFluent;
 
 namespace FizzCode.EtLast;
 
@@ -45,7 +46,7 @@ public string HostArgumentsFolder
     }
 
     [EditorBrowsable(EditorBrowsableState.Never)]
-    public Action<ISessionBuilder, IArgumentCollection> SessionConfigurator { get; internal set; }
+    public SessionBuilderAction SessionConfigurator { get; internal set; }
 
     public ConsoleHost(string name)
         : base(name)

diff --git a/EtLast.ConsoleHost/ConsoleHostFluent.cs b/EtLast.ConsoleHost/ConsoleHostFluent.cs
@@ -38,7 +38,9 @@ public static T SetModuleCompilationMode<T>(this T host, ModuleCompilationMode m
         return host;
     }
 
-    public static T ConfigureSession<T>(this T host, Action<ISessionBuilder, IArgumentCollection> builderAction)
+    public delegate void SessionBuilderAction(ISessionBuilder builder, IArgumentCollection sessionArguments);
+
+    public static T ConfigureSession<T>(this T host, SessionBuilderAction builderAction)
         where T : ConsoleHost
     {
         host.SessionConfigurator = builderAction;

diff --git a/EtLast.ConsoleHost/ConsoleHostSessionBuilderExtensions.cs b/EtLast.ConsoleHost/ConsoleHostSessionBuilderExtensions.cs
@@ -3,7 +3,7 @@
 [EditorBrowsable(EditorBrowsableState.Never)]
 public static class ConsoleHostSessionBuilderExtensions
 {
-    public static ISessionBuilder UseRollingDevLogManifestFiles(this ISessionBuilder session, int? maxFileCount, int? maxSizeOnDisk = 16 * 1024 * 1024)
+    public static ISessionBuilder UseRollingDevLogManifestFiles(this ISessionBuilder session, int? maxFileCount = null, int? maxSizeOnDisk = 64 * 1024 * 1024)
     {
         var folder = Path.Combine(session.DevLogFolder, "manifest");
         CleanupManifestFolder(maxFileCount, maxSizeOnDisk, folder);

diff --git a/Samples/Sample.Etl.Host/Program.cs b/Samples/Sample.Etl.Host/Program.cs
@@ -4,4 +4,5 @@
     .UseCommandListener(hostArguments => new ConsoleCommandListener())
     .SetAlias("test", "test-modules -a")
     .SetAlias("load", "run SampleModule Load")
+    .ConfigureSession((builder, sessionArguments) => builder.UseRollingDevLogManifestFiles())
     .Run();
diff --git a/Tests/EtLast.Tests.Integration/Program.cs b/Tests/EtLast.Tests.Integration/Program.cs
@@ -20,7 +20,7 @@
     //.DisableSerilogForModules()
     //.DisableSerilogForCommands()
 
-    .ConfigureSession((builder, args) => builder.UseRollingDevLogManifestFiles(null))
+    .ConfigureSession((builder, sessionArguments) => builder.UseRollingDevLogManifestFiles(null))
 
     .IfInstanceIs("WSDEVONE", host => host
         .IfDebuggerAttached(host => host