Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/components/FlagsTab/ExpandableRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { FlagsmithLink } from '../shared';
import { buildFlagUrl } from '../../theme/flagsmithTheme';
import { EnvironmentTable } from './EnvironmentTable';
import { FeatureDetailsGrid } from './FeatureDetailsGrid';
import { SegmentOverridesSection } from './SegmentOverridesSection';

const useStyles = makeStyles(theme => ({
flagName: {
Expand Down Expand Up @@ -81,8 +80,6 @@ export const ExpandableRow = ({
};

const liveVersion = details?.liveVersion || feature.live_version;
const segmentOverrides =
details?.segmentOverrides ?? feature.num_segment_overrides ?? 0;
const flagUrl = buildFlagUrl(
projectId,
primaryEnvId?.toString() || '',
Expand Down Expand Up @@ -152,7 +149,6 @@ export const ExpandableRow = ({
<FeatureDetailsGrid
feature={feature}
liveVersion={liveVersion}
segmentOverrides={segmentOverrides}
/>

<Grid item xs={12}>
Expand All @@ -161,14 +157,6 @@ export const ExpandableRow = ({
environments={environments}
/>
</Grid>

<Grid item xs={12}>
<SegmentOverridesSection
feature={feature}
details={details}
liveVersion={liveVersion}
/>
</Grid>
</Grid>
)}
</Box>
Expand Down
19 changes: 0 additions & 19 deletions src/components/FlagsTab/FeatureDetailsGrid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,11 @@ type LiveVersionInfo = FlagsmithFeature['live_version'];
interface FeatureDetailsGridProps {
feature: FlagsmithFeature;
liveVersion: LiveVersionInfo;
segmentOverrides: number;
}

export const FeatureDetailsGrid = ({
feature,
liveVersion,
segmentOverrides,
}: FeatureDetailsGridProps) => {
const classes = useStyles();

Expand All @@ -47,23 +45,6 @@ export const FeatureDetailsGrid = ({
</Grid>
)}

<Grid item xs={12} md={4}>
<Box className={classes.detailCard}>
<Typography variant="subtitle2" gutterBottom>
Targeting
</Typography>
<Typography variant="body2">
Segment overrides: {segmentOverrides}
</Typography>
{feature.num_identity_overrides !== null &&
feature.num_identity_overrides !== undefined && (
<Typography variant="body2">
Identity overrides: {feature.num_identity_overrides}
</Typography>
)}
</Box>
</Grid>

<Grid item xs={12} md={4}>
<Box className={classes.detailCard}>
<Typography variant="subtitle2" gutterBottom>
Expand Down
163 changes: 0 additions & 163 deletions src/components/FlagsTab/SegmentOverridesSection.tsx

This file was deleted.

42 changes: 0 additions & 42 deletions src/components/FlagsmithOverviewCard/FlagStatsRow.tsx

This file was deleted.

6 changes: 1 addition & 5 deletions src/components/FlagsmithOverviewCard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ import { useEntity } from '@backstage/plugin-catalog-react';
import { FlagsmithLink, MiniPagination, LoadingState } from '../shared';
import { buildProjectUrl } from '../../theme/flagsmithTheme';
import { useFlagsmithProject } from '../../hooks';
import { calculateFeatureStats, paginate } from '../../utils';
import { FlagStatsRow } from './FlagStatsRow';
import { paginate } from '../../utils';
import { FeatureFlagRow } from './FeatureFlagRow';

const useStyles = makeStyles(theme => ({
Expand Down Expand Up @@ -62,7 +61,6 @@ export const FlagsmithOverviewCard = () => {
page,
PAGE_SIZE,
);
const { enabledCount, disabledCount } = calculateFeatureStats(features);
const dashboardUrl = buildProjectUrl(
projectId || '',
environments[0]?.id?.toString(),
Expand All @@ -78,8 +76,6 @@ export const FlagsmithOverviewCard = () => {
</Box>
}
>
<FlagStatsRow enabledCount={enabledCount} disabledCount={disabledCount} />

<TableContainer component={Paper} variant="outlined">
<Table size="small">
<TableHead>
Expand Down
14 changes: 0 additions & 14 deletions src/utils/flagHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,6 @@ export function buildEnvStatusTooltip(
.join(' • ');
}

/**
* Calculate enabled/disabled feature counts.
*/
export function calculateFeatureStats(features: FlagsmithFeature[]): {
enabledCount: number;
disabledCount: number;
} {
const enabledCount = features.filter(f => f.default_enabled).length;
return {
enabledCount,
disabledCount: features.length - enabledCount,
};
}

/**
* Paginate an array of items.
*/
Expand Down
1 change: 0 additions & 1 deletion src/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export {
getFeatureEnvStatus,
buildEnvStatusTooltip,
calculateFeatureStats,
paginate,
} from './flagHelpers';